Re: [pulseaudio-discuss] [PATCH] sbc_math.h: add explicit check for ARMv6 instructions

On Mon, Mar 28, 2011 at 6:41 PM, Luiz Augusto von Dentz
[off-list ref] wrote:

Hi,

On Fri, Mar 25, 2011 at 1:34 PM, Paul Menzel
[off-list ref] wrote:

quoted

Dear Arun,


Am Samstag, den 19.03.2011, 16:14 +0530 schrieb Arun Raghavan:

quoted

On Wed, 2011-02-23 at 01:07 +0530, Arun Raghavan wrote:
[...]

quoted

The correct fix for this, imo, is in bluez (there is a new
sbc_primitives_armv6.h that can probably be used at least as a
template). We need to do an sbc-udpate on the PA side anyway, and can
pull this when we do.

Could you see if the attached patch works for you? If it does, I can
push this to the bluez folks.

-#ifdef __arm__
+#ifdef SBC_HAVE_THUMB2

I think this check can be just changed to
#if defined(__arm__) && (!defined(__thumb__) || defined(__thumb2__))

MLA instruction is available on all ARM processors at least since
armv4, unless compiling code for thumb1. A similar modification can be
also added to armv6 sbc encoder optimizations. Right now armv6
assembly optimizations are disabled for both thumb1 and thumb2, while
they could be still used with thumb2.

-- 
Best regards,
Siarhei Siamashka