Re: [PATCH 5/5] Fix --enable-usb build

Hi,

On Tue, Feb 22, 2011 at 4:05 PM, Vinicius Costa Gomes
[off-list ref] wrote:

Hi Luiz,

On 11:43 Tue 22 Feb, Luiz Augusto von Dentz wrote:

quoted

From: Luiz Augusto von Dentz <redacted>

---
 configure.ac |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/configure.ac b/configure.ac
index 602c948..fc63b8c 100644
--- a/configure.ac
+++ b/configure.ac

@@ -156,7 +156,7 @@ AC_ARG_ENABLE(usb, AC_HELP_STRING([--enable-usb],

      enable_usb=${enableval}
 ])
 AM_CONDITIONAL(USB, test "${enable_usb}" = "yes" &&
-                             test "${enable_server}" != "no")
+                             test "${enable_usb}" != "no")

I failed to notice how the new line that you added is different from the
first line of the AM_CONDITIONAL(). Perhaps just removing the "enable_server"
test is enough. Or am I missing something?

quoted

 AC_ARG_ENABLE(pcsuite, AC_HELP_STRING([--enable-pcsuite],
                              [enable Nokia PcSuite plugin]), [
--

Actually this is wrong, I though it was a type but it is not, but you
are right we should not need to check for server there as we do
already in Makefile.am.


-- 
Luiz Augusto von Dentz
Computer Engineer