Re: [RFC v2 03/14] Add att_get_u128
From: Anderson Lizardo <hidden>
Date: 2011-02-22 17:24:16
Hi Claudio, On Fri, Feb 18, 2011 at 7:29 PM, Claudio Takahasi [off-list ref] wrote:
Function to convert 128-bits values from little endian to host order. Different than SDP, ATT uses little endian format. --- attrib/att.c | 12 ++++++++---- attrib/att.h | 10 ++++++++++ attrib/gatt.c | 13 ++++++++----- attrib/gatttool.c | 6 ++++-- 4 files changed, 30 insertions(+), 11 deletions(-)
This patch could be refactored by adding a hton128() call before calling sdp_uuid128_create(). This way we fix the valid bug where we are not passing big-endian ordered bytes to sdp_uuid28_create(). What do you think? At least the att_get_u128() function is still valid and needs to be applied IMHO. Regards, -- Anderson Lizardo Instituto Nokia de Tecnologia - INdT Manaus - Brazil