Re: [PATCH v2 3/7] Create helper functions to deal with handles on interactive gatttool
From: Sheldon Demario <hidden>
Date: 2011-02-23 13:23:34
Hi Johan On Wed, Feb 23, 2011 at 12:09 AM, Johan Hedberg [off-list ref] wrote:
Hi Sheldon, On Tue, Feb 22, 2011, Sheldon Demario wrote:quoted
+ *dst = strtoll(src, &e, 16); + if (errno != 0 || *e != '\0') { + return -1; }Firstly, you've got a coding style issue here: no {} for one-line scopes. Secondly, are you sure that this is the right way to check for strtoll failure? If there was some earlier libc function that failed errno might be set to != 0 even if strtoll succeeds, right? Or are all errno using libc functions guaranteed to set errno to 0 on success? Reading the man-page of strtoll it seems you should be checking for LLONG_MIN and LLONG_MAX return values.
If strtoll() returns LLONG_MIN or LLONG_MAX the errno is set to ERANGE so it is not need to check for these returning values. However, as Lizardo said, the errno must be set to 0 before strtoll() be called, so will send this fix. Sheldon.