Re: [PATCH 2/3] Bluetooth: Move index to common header in management interface

quoted

-       err = cmd_complete(sk, MGMT_OP_ADD_UUID, &dev_id, sizeof(dev_id));
+       err = cmd_complete(sk, index, MGMT_OP_ADD_UUID, &index, sizeof(index));

Is index still required to be passed as return parameter, now that it
is part of the header? This is the case for various other commands.

I've missed that, should be cmd_complete(sk, index, MGMT_OP_ADD_UUID, NULL, 0);
Will send fixed version. 

quoted

-       err = cmd_complete(sk, MGMT_OP_REMOVE_UUID, &dev_id, sizeof(dev_id));
+       err = cmd_complete(sk, index, MGMT_OP_REMOVE_UUID, NULL, 0);

Here controller index is not being passed as return parameter anymore,
so it looks inconsistent to me.

This one is correct.

In general, I think all commands which used to have controller index
as parameters (both cp and rp), would need to be modified because
index is already part of the header.

Actually all commands were modified, just missed to null parameters.
 

Also be sure to update doc/mgmt-api.txt from BlueZ.

Sure.

Regards,

BR
Szymon