[PATCH 2/2] bt hidp: send Output reports using SET_REPORT on the Control channel
From: Antonio Ospite <hidden>
Date: 2011-02-20 17:27:08
Also in:
linux-input
Subsystem:
bluetooth subsystem, the rest · Maintainers:
Marcel Holtmann, Luiz Augusto von Dentz, Linus Torvalds
Possibly related (same subject, not in this thread)
- 2011-02-22 · Re: [PATCH 2/2] bt hidp: send Output reports using SET_REPORT on the Control channel · Jiri Kosina <hidden>
- 2011-02-21 · Re: [PATCH 2/2] bt hidp: send Output reports using SET_REPORT on the Control channel · Gustavo F. Padovan <hidden>
- 2011-02-21 · Re: [PATCH 2/2] bt hidp: send Output reports using SET_REPORT on the Control channel · Jiri Kosina <hidden>
- 2011-02-21 · Re: [PATCH 2/2] bt hidp: send Output reports using SET_REPORT on the Control channel · Alan Ott <hidden>
The current implementation of hidp_output_raw_report() relies only on the Control channel even for Output reports, and the BT HID specification [1] does not mention using the DATA message for Output reports on the Control channel (see section 7.9.1 and also Figure 11: SET_ Flow Chart), so let us just use SET_REPORT. This also fixes sending Output reports to some devices (like Sony Sixaxis) which are not able to handle DATA messages on the Control channel. Ideally hidp_output_raw_report() could be improved to use this scheme: Feature Report -- SET_REPORT on the Control channel Output Report -- DATA on the Interrupt channel for more efficiency, but as said above, right now only the Control channel is used. [1] http://www.bluetooth.com/Specification%20Documents/HID_SPEC_V10.pdf Signed-off-by: Antonio Ospite <redacted> --- net/bluetooth/hidp/core.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/bluetooth/hidp/core.c b/net/bluetooth/hidp/core.c
index 6df8ea1..3c036b0 100644
--- a/net/bluetooth/hidp/core.c
+++ b/net/bluetooth/hidp/core.c@@ -405,7 +405,7 @@ static int hidp_output_raw_report(struct hid_device *hid, unsigned char *data, s report_type = HIDP_TRANS_SET_REPORT | HIDP_DATA_RTYPE_FEATURE; break; case HID_OUTPUT_REPORT: - report_type = HIDP_TRANS_DATA | HIDP_DATA_RTYPE_OUPUT; + report_type = HIDP_TRANS_SET_REPORT | HIDP_DATA_RTYPE_OUPUT; break; default: return -EINVAL;
--
1.7.4.1