Re: [PATCH] Fix signal watch when a service name is given

Hi,

On Tue, Feb 16, 2010 at 5:58 PM, Luiz Augusto von Dentz
[off-list ref] wrote:

Hi Marcel,

On Tue, Feb 16, 2010 at 5:37 PM, Marcel Holtmann [off-list ref] wrote:

quoted

Hi Luiz,

quoted

quoted

This should fix g_dbus_add_signal_watch when a service like org.bluez is given.

Updating since the last one was broken.

I also think that in check_service() we actually have a missing call to
dbus_pending_unref(). That would cause a memory leak.

There is a call to  dbus_pending_call_unref on check_service after
dbus_pending_call_set_notify, which I took a look and seems correct
but we have another problem there since we never cancel the pending
call if the filter is unregister. Anyway there is a leak on
service_reply where I don't call dbus_message_unref, so I will come up
with another update soon.

Now with the memory leaks fixed.

-- 
Luiz Augusto von Dentz
Computer Engineer