Hi,
On Tue, Sep 8, 2009 at 7:28 PM, Johan Hedberg [off-list ref] wrote:
- Use /* .. */ for comments instead of //
- Make sure your lines are max 80 columns (e.g. shorten the debug message
or split it into two lines if necessary)
- commit it to your own tree with a descriptive commit message and prepare
a patch using "git format-patch". This way it's easy for me to apply it
using "git am" and e.g. the author field gets correctly preserved.
Besides this it seems pretty good, please also make sure the DBus
signals are right, which in this case means we shouldn't emit
disconnected when dropping the second connection attempt, you can use
dbus-monitor --system sender='org.bluez'.
Regards,
--
Luiz Augusto von Dentz
Engenheiro de Computação