Re: [PATCH] PS3Remote unpairing and power-saving

On Fri, 2009-09-18 at 15:31 +0200, Ruslan N. Marchenko wrote:

Hi Bastien,

Thanks for finding your time for review.

2009/9/18, Bastien Nocera [off-list ref]:

quoted

Don't use statics, add those to a ps3 specific struct.

This function is ps3remote_event which supposed to be use for ps3remote only,
also the driver assumes only single ps3remote device per bluez instance.
I just copied semantic from ps3remote_decode function, where also 2
statics are used. Though I can move them all to input structure.
Should I?

Please. And if you manage to make it handle more than one remote in the
process, then all the better.

quoted

quoted

+     g_timer_start(((struct fake_hid *)fake->priv)->timer);

Why do you start the timer unconditionally, instead of just when using
 the HOME key?

Because this statement is to reset event timer, which causes remote to
be disconnected on idle. Each key-press resets the timer
unconditionally. g_timer_start is recommended to use instead of
g_timer_reset since they do the same thing and reset will be
deprecated (I guess).

Looks fine.

Cheers