Re: [PATCH] init and extra checking fixups
From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date: 2009-09-27 03:01:08
Hi Steve, On Sat, Sep 26, 2009 at 1:37 PM, Steve Grubb [off-list ref] wrote:
quoted hunk ↗ jump to hunk
diff -urp bluez-4.54.orig/audio/control.c bluez-4.54/audio/control.c--- bluez-4.54.orig/audio/control.c 2009-09-26 08:43:56.000000000 -0400 +++ bluez-4.54/audio/control.c 2009-09-26 11:24:04.000000000 -0400@@ -472,7 +472,7 @@ static gboolean control_cb(GIOChannel *cstruct avrcp_header *avrcp; int ret, packet_size, operand_count, sock; - if (!(cond | G_IO_IN)) + if (!(cond & G_IO_IN)) goto failed;
I don't think this is actually right, if we change it to AND operation it would mean we won't process any other error condition if it happens together with G_IO_IN, but still the OR seems wrong here, normally we use the following check which I believe is more appropriate: if (cond & (G_IO_HUP | G_IO_ERR)) goto failed; -- Luiz Augusto von Dentz Engenheiro de Computação