Re: can we increase the send buffer size of rfcomm socket?

Hi Lain,

2009/8/29 Iain Hibbert [off-list ref]:

On Fri, 28 Aug 2009, Marcel Holtmann wrote:

quoted

quoted

Yes, it's our kernel's problem. We used another version and it worked
fine. Here the change in rfcomm_sock_alloc() is only for testing. What
I'm doing now is adding a case for RFCOMM_SNDBUF in the function
rfcomm_sock_setsockopt_old(), as below.

=A0 =A0 case RFCOMM_SNDBUF:
=A0 =A0 =A0 =A0 =A0 =A0 sk->sk_sndbuf =3D opt;
=A0 =A0 =A0 =A0 =A0 =A0 break;

I'm thinking to add a limitation for a maximum buffer size, but don't
know what maximum size is appropriate here. Do you have any idea?

no that is bluntly wrong. Why do you think the function has _old in its
name. It clearly shows that we are going to deprecate it soon. If you do
this for RFCOMM, then it should also be done for L2CAP. So make sure you
use SOL_BLUETOOTH. And make it similar to what TCP is doing.

Eh? Why would you need to invent a SOL_BLUETOOTH setting for this when
there is a standard "SOL_SOCKET, SO_SNDBUF" option that covers it already=

?

=A0http://www.opengroup.org/onlinepubs/000095399/functions/setsockopt.htm=

l

regards,
iain

Lain, you are right. I tried setsockopt with level SOL_SOCKET and opt
SO_SNDBUF, it worked well. So, Bluetooth socket can set all the
standard sock options, no need to add extra code for that. Thanks a
lot for your suggestion.

Marcel, also thank you for considering this issue these days.

Thanks,
Zhu Lan