Re: [Bluez-devel] [PATCH] Advertise Telephony service class when device offers headset AG or handsfree AG

On Sat, Aug 30, 2008 at 1:58 AM, Marcel Holtmann [off-list ref]wrote:

Hi Nick,

quoted

 src/sdpd-service.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/src/sdpd-service.c b/src/sdpd-service.c
index cf120b8..df9017e 100644
--- a/src/sdpd-service.c
+++ b/src/sdpd-service.c

@@ -125,6 +125,8 @@ static void update_svclass_list(void)
              case INTERCOM_SVCLASS_ID:
              case FAX_SVCLASS_ID:
              case SAP_SVCLASS_ID:
+             case HEADSET_AGW_SVCLASS_ID:
+             case HANDSFREE_AGW_SVCLASS_ID:
                      val |= 0x40;    /* Telephony */
                      break;
              case AUDIO_SOURCE_SVCLASS_ID:

do you have a reference to a spec. for this one. The automatic service
class adjustment has been done according to the spec.

I didn't even know there existed a spec for these service classes. I thought
they were rather arbitrary. But it certainly makes sense that if offer
headset or handsfree audio gateway you are a telephone.


I could have

missed one or two, but I am quite sure I didn't. So while it looks okay,
we have to make sure that we didn't violate the specs.

Regards

Marcel



-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's
challenge
Build the coolest Linux based applications with Moblin SDK & win great
prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel