Thread (23 messages) 23 messages, 3 authors, 2025-12-16

Re: [PATCH 6/9] blk-crypto: use on-stack skcipher requests for fallback en/decryption

From: Eric Biggers <ebiggers@kernel.org>
Date: 2025-12-13 01:01:00
Also in: linux-fscrypt, linux-fsdevel

On Wed, Dec 10, 2025 at 04:23:35PM +0100, Christoph Hellwig wrote:
Allocating a skcipher request dynamically can deadlock or cause
unexpected I/O failures when called from writeback context.  Avoid the
allocation entirely by using on-stack skciphers, similar to what the
non-blk-crypto fscrypt path already does.

This drops the incomplete support for asynchronous algorithms, which
previously could be used, but only synchronously.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 block/blk-crypto-fallback.c | 178 ++++++++++++++++--------------------
 1 file changed, 79 insertions(+), 99 deletions(-)
Reviewed-by: Eric Biggers <ebiggers@kernel.org>

- Eric
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help