Re: [PATCH 4/9] blk-crypto: submit the encrypted bio in blk_crypto_fallback_bio_prep
From: Eric Biggers <ebiggers@kernel.org>
Date: 2025-12-13 00:48:36
Also in:
linux-fscrypt, linux-fsdevel
On Wed, Dec 10, 2025 at 04:23:33PM +0100, Christoph Hellwig wrote:
quoted hunk ↗ jump to hunk
@@ -502,8 +495,10 @@ bool blk_crypto_fallback_bio_prep(struct bio **bio_ptr)if (!__blk_crypto_cfg_supported(blk_crypto_fallback_profile, &bc->bc_key->crypto_cfg)) { bio->bi_status = BLK_STS_NOTSUPP; return false; }
The above is missing a call to bio_endio().
+ * In either case, this function will make the submitted bio look like a regular + * bio (i.e. as if no encryption context was ever specified) for the purposes of + * the rest of the stack except for blk-integrity (blk-integrity and blk-crypto + * are not currently supported together).
Maybe "submitted bio" => "submitted bio(s)", considering that there can be multiple. Or put this information in the preceding paragraphs that describe the WRITE and READ cases. Otherwise this patch looks good. I'm not 100% sure the split case still works correctly, but it's not really important because the next patch in the series rewrites it anyway. - Eric