Re: [PATCH v4 1/5] fs, block: refactor enum rw_hint
From: Bart Van Assche <bvanassche@acm.org>
Date: 2024-08-26 17:44:15
Also in:
linux-f2fs-devel, linux-fsdevel, linux-nvme, linux-scsi
On 8/26/24 10:06 AM, Kanchan Joshi wrote:
Change i_write_hint (in inode), bi_write_hint (in bio) and write_hint (in request) to use u8 data-type rather than this enum.
That sounds fishy to me. Why to increase the size of this enum? Why to reduce the ability of the compiler to perform type checking? I think this needs to be motivated clearly in the patch description. Bart.