Thread (33 messages) 33 messages, 3 authors, 2023-08-16

Re: [PATCH v8 2/9] block/mq-deadline: Only use zone locking if necessary

From: Bart Van Assche <bvanassche@acm.org>
Date: 2023-08-14 17:01:29
Also in: linux-scsi

On 8/14/23 05:33, Damien Le Moal wrote:
On 8/12/23 06:35, Bart Van Assche wrote:
quoted
@@ -934,7 +936,7 @@ static void dd_finish_request(struct request *rq)
  
  	atomic_inc(&per_prio->stats.completed);
  
-	if (blk_queue_is_zoned(q)) {
+	if (rq->q->limits.use_zone_write_lock) {
This is all nice and simple ! However, an inline helper to check
rq->q->limits.use_zone_write_lock would be nice. E.g.
blk_queue_use_zone_write_lock() ?
Hi Damien,

Do you perhaps want me to introduce a function that does nothing else than
returning the value of q->limits.use_zone_write_lock? I'm asking this because
recently I have seen a fair number of patches that remove functions that do
nothing else than returning the value of a single member variable.

Thanks,

Bart.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help