Thread (33 messages) 33 messages, 3 authors, 2023-08-16
STALE1068d REVIEWED: 1 (0M)
Revisions (3)
  1. v8 current
  2. v9 [diff vs current]
  3. v10 [diff vs current]

[PATCH v8 8/9] scsi: ufs: Split an if-condition

From: Bart Van Assche <bvanassche@acm.org>
Date: 2023-08-11 21:36:40
Also in: linux-scsi
Subsystem: scsi subsystem, the rest, universal flash storage host controller driver · Maintainers: "James E.J. Bottomley", "Martin K. Petersen", Linus Torvalds

Make the next patch in this series easier to read. No functionality is
changed.

Reviewed-by: Can Guo <redacted>
Cc: Martin K. Petersen <martin.petersen@oracle.com>
Cc: Avri Altman <avri.altman@wdc.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Damien Le Moal <dlemoal@kernel.org>
Cc: Ming Lei <redacted>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
 drivers/ufs/core/ufshcd.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
index 129446775796..ae7b868f9c26 100644
--- a/drivers/ufs/core/ufshcd.c
+++ b/drivers/ufs/core/ufshcd.c
@@ -4352,8 +4352,9 @@ void ufshcd_auto_hibern8_update(struct ufs_hba *hba, u32 ahit)
 	}
 	spin_unlock_irqrestore(hba->host->host_lock, flags);
 
-	if (update &&
-	    !pm_runtime_suspended(&hba->ufs_device_wlun->sdev_gendev)) {
+	if (!update)
+		return;
+	if (!pm_runtime_suspended(&hba->ufs_device_wlun->sdev_gendev)) {
 		ufshcd_rpm_get_sync(hba);
 		ufshcd_hold(hba);
 		ufshcd_auto_hibern8_enable(hba);
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help