Thread (45 messages) 45 messages, 8 authors, 2023-09-04

Re: [PATCH 09/12] ext4: drop s_umount over opening the log device

From: Christian Brauner <brauner@kernel.org>
Date: 2023-08-03 18:17:25
Also in: linux-btrfs, linux-ext4, linux-f2fs-devel, linux-fsdevel, linux-xfs

On Wed, Aug 02, 2023 at 05:41:28PM +0200, Christoph Hellwig wrote:
Just like get_tree_bdev needs to drop s_umount when opening the main
device, we need to do the same for the ext4 log device to avoid a
potential lock order reversal with s_unmount for the mark_dead path.

It might be preferable to just drop s_umount over ->fill_super entirely,
but that will require a fairly massive audit first, so we'll do the easy
version here first.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
Looks good to me,
Reviewed-by: Christian Brauner <brauner@kernel.org>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help