Re: [PATCH 05/12] ext4: make the IS_EXT2_SB/IS_EXT3_SB checks more robust

more blkdev_get and holder work · Christoph Hellwig <hch@lst.de> · 2023-08-02
[PATCH 01/12] fs: export setup_bdev_super · Christoph Hellwig <hch@lst.de> · 2023-08-02
Re: [PATCH 01/12] fs: export setup_bdev_super · Christian Brauner <brauner@kernel.org> · 2023-08-03
Re: [f2fs-dev] [PATCH 01/12] fs: export setup_bdev_super · patchwork-bot+f2fs@kernel.org · 2023-09-04
[PATCH 02/12] nilfs2: use setup_bdev_super to de-duplicate the mount code · Christoph Hellwig <hch@lst.de> · 2023-08-02
Re: [PATCH 02/12] nilfs2: use setup_bdev_super to de-duplicate the mount code · Jan Kara <jack@suse.cz> · 2023-08-03
Re: [PATCH 02/12] nilfs2: use setup_bdev_super to de-duplicate the mount code · Ryusuke Konishi <konishi.ryusuke@gmail.com> · 2023-08-04
Re: [PATCH 02/12] nilfs2: use setup_bdev_super to de-duplicate the mount code · Jan Kara <jack@suse.cz> · 2023-08-10
Re: [PATCH 02/12] nilfs2: use setup_bdev_super to de-duplicate the mount code · Ryusuke Konishi <konishi.ryusuke@gmail.com> · 2023-08-10
Re: [PATCH 02/12] nilfs2: use setup_bdev_super to de-duplicate the mount code · Jan Kara <jack@suse.cz> · 2023-08-10
Re: [PATCH 02/12] nilfs2: use setup_bdev_super to de-duplicate the mount code · Ryusuke Konishi <konishi.ryusuke@gmail.com> · 2023-08-04
[PATCH 03/12] btrfs: always open the device read-only in btrfs_scan_one_device · Christoph Hellwig <hch@lst.de> · 2023-08-02
[PATCH 04/12] btrfs: open block devices after superblock creation · Christoph Hellwig <hch@lst.de> · 2023-08-02
[PATCH 05/12] ext4: make the IS_EXT2_SB/IS_EXT3_SB checks more robust · Christoph Hellwig <hch@lst.de> · 2023-08-02
Re: [PATCH 05/12] ext4: make the IS_EXT2_SB/IS_EXT3_SB checks more robust · Jan Kara <jack@suse.cz> · 2023-08-03
Re: [PATCH 05/12] ext4: make the IS_EXT2_SB/IS_EXT3_SB checks more robust · Christian Brauner <brauner@kernel.org> · 2023-08-03
Re: [PATCH 05/12] ext4: make the IS_EXT2_SB/IS_EXT3_SB checks more robust · "Theodore Ts'o" <tytso@mit.edu> · 2023-08-04
[PATCH 06/12] fs: use the super_block as holder when mounting file systems · Christoph Hellwig <hch@lst.de> · 2023-08-02
Re: [PATCH 06/12] fs: use the super_block as holder when mounting file systems · Jan Kara <jack@suse.cz> · 2023-08-03
Re: [PATCH 06/12] fs: use the super_block as holder when mounting file systems · Jan Kara <jack@suse.cz> · 2023-08-03
Re: [PATCH 06/12] fs: use the super_block as holder when mounting file systems · Christoph Hellwig <hch@lst.de> · 2023-08-05
Re: [PATCH 06/12] fs: use the super_block as holder when mounting file systems · Christian Brauner <brauner@kernel.org> · 2023-08-03
[PATCH 07/12] fs: stop using get_super in fs_mark_dead · Christoph Hellwig <hch@lst.de> · 2023-08-02
Re: [PATCH 07/12] fs: stop using get_super in fs_mark_dead · Jan Kara <jack@suse.cz> · 2023-08-03
Re: [PATCH 07/12] fs: stop using get_super in fs_mark_dead · Christian Brauner <brauner@kernel.org> · 2023-08-03
[PATCH 09/12] ext4: drop s_umount over opening the log device · Christoph Hellwig <hch@lst.de> · 2023-08-02
Re: [PATCH 09/12] ext4: drop s_umount over opening the log device · Jan Kara <jack@suse.cz> · 2023-08-03
Re: [PATCH 09/12] ext4: drop s_umount over opening the log device · Christian Brauner <brauner@kernel.org> · 2023-08-03
Re: [PATCH 09/12] ext4: drop s_umount over opening the log device · "Theodore Ts'o" <tytso@mit.edu> · 2023-08-04
[PATCH 11/12] xfs: drop s_umount over opening the log and RT devices · Christoph Hellwig <hch@lst.de> · 2023-08-02
Re: [PATCH 11/12] xfs: drop s_umount over opening the log and RT devices · "Darrick J. Wong" <djwong@kernel.org> · 2023-08-02
Re: [PATCH 11/12] xfs: drop s_umount over opening the log and RT devices · Christoph Hellwig <hch@lst.de> · 2023-08-05
Re: [PATCH 11/12] xfs: drop s_umount over opening the log and RT devices · Christian Brauner <brauner@kernel.org> · 2023-08-05
Re: [PATCH 11/12] xfs: drop s_umount over opening the log and RT devices · "Darrick J. Wong" <djwong@kernel.org> · 2023-08-05
Re: [PATCH 11/12] xfs: drop s_umount over opening the log and RT devices · Christian Brauner <brauner@kernel.org> · 2023-08-05
[PATCH 10/12] ext4: use fs_holder_ops for the log device · Christoph Hellwig <hch@lst.de> · 2023-08-02
Re: [PATCH 10/12] ext4: use fs_holder_ops for the log device · Jan Kara <jack@suse.cz> · 2023-08-03
[PATCH 08/12] fs: export fs_holder_ops · Christoph Hellwig <hch@lst.de> · 2023-08-02
Re: [PATCH 08/12] fs: export fs_holder_ops · Jan Kara <jack@suse.cz> · 2023-08-03
Re: [PATCH 08/12] fs: export fs_holder_ops · Christian Brauner <brauner@kernel.org> · 2023-08-03
[PATCH 12/12] xfs use fs_holder_ops for the log and RT devices · Christoph Hellwig <hch@lst.de> · 2023-08-02
Re: [PATCH 12/12] xfs use fs_holder_ops for the log and RT devices · "Darrick J. Wong" <djwong@kernel.org> · 2023-08-02
Re: [PATCH 12/12] xfs use fs_holder_ops for the log and RT devices · Carlos Maiolino <cem@kernel.org> · 2023-08-14
Re: [PATCH 12/12] xfs use fs_holder_ops for the log and RT devices · Carlos Maiolino <cem@kernel.org> · 2023-08-14
Re: more blkdev_get and holder work · Christian Brauner <brauner@kernel.org> · 2023-08-04

From: Christian Brauner <brauner@kernel.org>
Date: 2023-08-03 18:11:02
Also in: linux-btrfs, linux-ext4, linux-f2fs-devel, linux-fsdevel, linux-xfs

On Wed, Aug 02, 2023 at 05:41:24PM +0200, Christoph Hellwig wrote:

Check for sb->s_type which is the right place to look at the file system
type, not the holder, which is just an implementation detail in the VFS
helpers.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---

Looks good to me,
Reviewed-by: Christian Brauner <brauner@kernel.org>

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help