Thread (75 messages) 75 messages, 5 authors, 2023-01-24

Re: [PATCH v8 04/10] iomap: don't get an reference on ZERO_PAGE for direct I/O block zeroing

From: David Hildenbrand <hidden>
Date: 2023-01-24 14:30:39
Also in: linux-fsdevel, lkml

On 23.01.23 18:30, David Howells wrote:
quoted hunk ↗ jump to hunk
From: Christoph Hellwig <hch@lst.de>

ZERO_PAGE can't go away, no need to hold an extra reference.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: David Howells <dhowells@redhat.com>
---
  fs/iomap/direct-io.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c
index 9804714b1751..47db4ead1e74 100644
--- a/fs/iomap/direct-io.c
+++ b/fs/iomap/direct-io.c
@@ -202,7 +202,7 @@ static void iomap_dio_zero(const struct iomap_iter *iter, struct iomap_dio *dio,
  	bio->bi_private = dio;
  	bio->bi_end_io = iomap_dio_bio_end_io;
  
-	get_page(page);
+	bio_set_flag(bio, BIO_NO_PAGE_REF);
  	__bio_add_page(bio, page, len, 0);
  	iomap_dio_submit_bio(iter, dio, bio, pos);
  }
Reviewed-by: David Hildenbrand <redacted>

-- 
Thanks,

David / dhildenb
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help