Re: [RFC PATCH 2/3] nvme: add copy offload support
From: Bart Van Assche <bvanassche@acm.org>
Date: 2022-02-01 19:18:23
Also in:
dm-devel, linux-fsdevel, linux-nvme, linux-scsi
From: Bart Van Assche <bvanassche@acm.org>
Date: 2022-02-01 19:18:23
Also in:
dm-devel, linux-fsdevel, linux-nvme, linux-scsi
On 2/1/22 10:33, Mikulas Patocka wrote:
+static inline blk_status_t nvme_setup_read_token(struct nvme_ns *ns, struct request *req)
+{
+ struct bio *bio = req->bio;
+ struct nvme_copy_token *token = page_to_virt(bio->bi_io_vec[0].bv_page) + bio->bi_io_vec[0].bv_offset;Hmm ... shouldn't this function use bvec_kmap_local() instead of page_to_virt()? Thanks, Bart.