Re: [PATCH 1/3] block: move freeing disk into queue's release handler
From: Ming Lei <hidden>
Date: 2022-01-18 16:05:20
From: Ming Lei <hidden>
Date: 2022-01-18 16:05:20
On Tue, Jan 18, 2022 at 11:47:33PM +0800, Ming Lei wrote:
On Tue, Jan 18, 2022 at 09:22:59AM +0100, Christoph Hellwig wrote:quoted
How does this work for SCSI where we can detach the disk from the request queue, reattach it and then maybe later free them both?Commit 8e141f9eb803 ("block: drain file system I/O on del_gendisk") has marked queue as dying, so how can the above case work given no any code clears the queue's dying flag?
oops, my fault, blk_queue_start_drain() actually doesn't set QUEUE_FLAG_DYING, so the rettach case works with commit 8e141f9eb803. Thanks, Ming