Re: [PATCH v3 3/3] blk-crypto: show crypto capabilities in sysfs

From
Bart Van Assche <bvanassche@acm.org>
Date
2021-12-14 05:04:38
Also in
linux-api, linux-mmc, linux-scsi, lkml
Reply to
Greg Kroah-Hartman, 2021-12-11
On 12/11/21 02:50, Greg Kroah-Hartman wrote:
On Fri, Dec 10, 2021 at 09:29:41AM -0800, Bart Van Assche wrote:
quoted
(b) No other block layer sysfs attribute follows this encoding scheme.
Then follow what they do.  Do they have multiple values in a single
file?  If so, they are broken and we should change that.
Hi Greg,

The only other block layer sysfs attribute I know of that reports multiple values is the queue/scheduler attribute. Here is an example of the output that can be produced by reading that attribute:

# cat /sys/block/sda/queue/scheduler
[mq-deadline] kyber bfq none

I don't think that changing the behavior of that attribute is an option because that would break existing user space software, e.g. the https://github.com/osandov/blktests/ test suite.

Thanks,

Bart.
Thread (19 messages) 19 messages, 4 authors, last reply 2021-12-14
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help