Re: [PATCH v3 2/3] block: don't delete queue kobject before its children

[PATCH v3 0/3] block: show crypto capabilities in sysfs · Eric Biggers <ebiggers@kernel.org> · 2021-12-08
[PATCH v3 3/3] blk-crypto: show crypto capabilities in sysfs · Eric Biggers <ebiggers@kernel.org> · 2021-12-08
Re: [PATCH v3 3/3] blk-crypto: show crypto capabilities in sysfs · Bart Van Assche <bvanassche@acm.org> · 2021-12-09
Re: [PATCH v3 3/3] blk-crypto: show crypto capabilities in sysfs · Eric Biggers <ebiggers@kernel.org> · 2021-12-09
Re: [PATCH v3 3/3] blk-crypto: show crypto capabilities in sysfs · Bart Van Assche <bvanassche@acm.org> · 2021-12-10
Re: [PATCH v3 3/3] blk-crypto: show crypto capabilities in sysfs · Eric Biggers <ebiggers@kernel.org> · 2021-12-10
Re: [PATCH v3 3/3] blk-crypto: show crypto capabilities in sysfs · Greg Kroah-Hartman <gregkh@linuxfoundation.org> · 2021-12-10
Re: [PATCH v3 3/3] blk-crypto: show crypto capabilities in sysfs · Bart Van Assche <bvanassche@acm.org> · 2021-12-10
Re: [PATCH v3 3/3] blk-crypto: show crypto capabilities in sysfs · Eric Biggers <ebiggers@kernel.org> · 2021-12-10
Re: [PATCH v3 3/3] blk-crypto: show crypto capabilities in sysfs · Greg Kroah-Hartman <gregkh@linuxfoundation.org> · 2021-12-11
Re: [PATCH v3 3/3] blk-crypto: show crypto capabilities in sysfs · Bart Van Assche <bvanassche@acm.org> · 2021-12-14
Re: [PATCH v3 3/3] blk-crypto: show crypto capabilities in sysfs · Chaitanya Kulkarni <hidden> · 2021-12-14
Re: [PATCH v3 3/3] blk-crypto: show crypto capabilities in sysfs · Greg Kroah-Hartman <gregkh@linuxfoundation.org> · 2021-12-14
[PATCH v3 2/3] block: don't delete queue kobject before its children · Eric Biggers <ebiggers@kernel.org> · 2021-12-08
Re: [PATCH v3 2/3] block: don't delete queue kobject before its children · Bart Van Assche <bvanassche@acm.org> · 2021-12-09
Re: [PATCH v3 2/3] block: don't delete queue kobject before its children · Eric Biggers <ebiggers@kernel.org> · 2021-12-09
Re: [PATCH v3 2/3] block: don't delete queue kobject before its children · Bart Van Assche <bvanassche@acm.org> · 2021-12-09
[PATCH v3 1/3] block: simplify calling convention of elv_unregister_queue() · Eric Biggers <ebiggers@kernel.org> · 2021-12-08
Re: [PATCH v3 1/3] block: simplify calling convention of elv_unregister_queue() · Bart Van Assche <bvanassche@acm.org> · 2021-12-09

From: Eric Biggers <ebiggers@kernel.org>
Date: 2021-12-09 23:17:42
Also in: linux-api, linux-mmc, linux-scsi, lkml

On Thu, Dec 09, 2021 at 02:38:02PM -0800, Bart Van Assche wrote:

On 12/7/21 5:35 PM, Eric Biggers wrote:

quoted

+	/* Now that all child objects were deleted, the queue can be deleted. */

Shouldn't the present tense be used above (were -> are)? Anyway:

Reviewed-by: Bart Van Assche <bvanassche@acm.org>

"deleted" is an action here, not a state.  I think it's fine as-is, but maybe
you would prefer the following?

	/* Now that we've deleted all child objects, we can delete the queue. */

- Eric

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help