Thread (20 messages) 20 messages, 5 authors, 2021-10-14

Re: [PATCH 5/7] scsi: add a scsi_alloc_request helper

From: Hannes Reinecke <hare@suse.de>
Date: 2021-10-14 07:37:49
Also in: linux-nfs, linux-scsi, target-devel

On 10/12/21 2:04 PM, Christoph Hellwig wrote:
Add a new helper that calls blk_get_request and initializes the
scsi_request to avoid the indirect call through ->.initialize_rq_fn.

Note that this makes the pktcdvd driver depend on the SCSI core, but
given that only SCSI devices support SCSI passthrough requests that
is not a functional change.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
  drivers/block/Kconfig              |  2 +-
  drivers/block/pktcdvd.c            |  2 +-
  drivers/scsi/scsi_bsg.c            |  4 ++--
  drivers/scsi/scsi_error.c          |  2 +-
  drivers/scsi/scsi_ioctl.c          |  4 ++--
  drivers/scsi/scsi_lib.c            | 19 +++++++++++++------
  drivers/scsi/sg.c                  |  4 ++--
  drivers/scsi/sr.c                  |  2 +-
  drivers/scsi/st.c                  |  2 +-
  drivers/target/target_core_pscsi.c |  3 +--
  include/scsi/scsi_cmnd.h           |  3 +++
  11 files changed, 28 insertions(+), 19 deletions(-)
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Kernel Storage Architect
hare@suse.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help