Re: [PATCH 3/7] nfsd/blocklayout: use ->get_unique_id instead of sending SCSI commands
From: Hannes Reinecke <hare@suse.de>
Date: 2021-10-14 07:32:37
Also in:
linux-nfs, linux-scsi, target-devel
From: Hannes Reinecke <hare@suse.de>
Date: 2021-10-14 07:32:37
Also in:
linux-nfs, linux-scsi, target-devel
On 10/12/21 2:04 PM, Christoph Hellwig wrote:
Call the ->get_unique_id method to query the SCSI identifiers. This can use the cached VPD page in the sd driver instead of sending a command on every LAYOUTGET. It will also allow to support NVMe based volumes if the draft for that ever takes off. Signed-off-by: Christoph Hellwig <hch@lst.de> --- fs/nfsd/Kconfig | 1 - fs/nfsd/blocklayout.c | 158 +++++++++++------------------------------- fs/nfsd/nfs4layouts.c | 5 +- 3 files changed, 44 insertions(+), 120 deletions(-)
Not that I'm an NFS expert, but anyway: Reviewed-by: Hannes Reinecke <hare@suse.de> Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer