Re: [PATCH 02/30] block: add a bdev_nr_bytes helper

From: Kees Cook <hidden>
Date: 2021-10-15 15:49:38
Also in: dm-devel, linux-bcache, linux-btrfs, linux-ext4, linux-fsdevel, linux-nfs, linux-nvme, linux-raid, linux-scsi, ntfs3, target-devel
Reply to: Anton Altaparmakov, 2021-10-15

On Fri, Oct 15, 2021 at 02:37:41PM +0000, Anton Altaparmakov wrote:

Hi Christoph,

quoted

On 15 Oct 2021, at 14:26, Christoph Hellwig [off-list ref] wrote:

Add a helpe to query the size of a block device in bytes.  This
will be used to remove open coded access to ->bd_inode.

Matthew already pointed out the return type for bdev_nr_bytes() but also your commit message has a typo: "Add a helpe" -> "Add a helper".

Right. With these fixed, I'm a fan. :)

Reviewed-by: Kees Cook <redacted>

-Kees

-- 
Kees Cook

Christoph Hellwig · 2021-10-15
[PATCH 02/30] block: add a bdev_nr_bytes helper · Christoph Hellwig · 2021-10-15
Re: [PATCH 02/30] block: add a bdev_nr_bytes helper · Matthew Wilcox · 2021-10-15
Re: [PATCH 02/30] block: add a bdev_nr_bytes helper · Christoph Hellwig · 2021-10-15
Re: [PATCH 02/30] block: add a bdev_nr_bytes helper · Anton Altaparmakov · 2021-10-15
Re: [PATCH 02/30] block: add a bdev_nr_bytes helper · Kees Cook · 2021-10-15
[PATCH 01/30] block: move the SECTOR_SIZE related definitions to blk_types.h · Christoph Hellwig · 2021-10-15
Re: [PATCH 01/30] block: move the SECTOR_SIZE related definitions to blk_types.h · Jan Kara · 2021-10-15
Re: [PATCH 01/30] block: move the SECTOR_SIZE related definitions to blk_types.h · Kees Cook · 2021-10-15
Re: [PATCH 01/30] block: move the SECTOR_SIZE related definitions to blk_types.h · Chaitanya Kulkarni · 2021-10-18
[PATCH 03/30] bcache: remove bdev_sectors · Christoph Hellwig · 2021-10-15
Re: [PATCH 03/30] bcache: remove bdev_sectors · Chaitanya Kulkarni · 2021-10-18
[PATCH 04/30] drbd: use bdev_nr_sectors instead of open coding it · Christoph Hellwig · 2021-10-15
Re: [PATCH 04/30] drbd: use bdev_nr_sectors instead of open coding it · Lee Duncan · 2021-10-15
[PATCH 05/30] dm: use bdev_nr_sectors and bdev_nr_bytes instead of open coding them · Christoph Hellwig · 2021-10-15
[PATCH 06/30] md: use bdev_nr_sectors instead of open coding it · Christoph Hellwig · 2021-10-15
[PATCH 07/30] nvmet: use bdev_nr_bytes instead of open coding it · Christoph Hellwig · 2021-10-15
Re: [PATCH 07/30] nvmet: use bdev_nr_bytes instead of open coding it · Kees Cook · 2021-10-15
[PATCH 09/30] fs: use bdev_nr_bytes instead of open coding it in blkdev_max_block · Christoph Hellwig · 2021-10-15
Re: [PATCH 09/30] fs: use bdev_nr_bytes instead of open coding it in blkdev_max_block · Kees Cook · 2021-10-15
[PATCH 08/30] target/iblock: use bdev_nr_bytes instead of open coding it · Christoph Hellwig · 2021-10-15
Re: [PATCH 08/30] target/iblock: use bdev_nr_bytes instead of open coding it · Kees Cook · 2021-10-15
[PATCH 10/30] fs: simplify init_page_buffers · Christoph Hellwig · 2021-10-15
[PATCH 12/30] btrfs: use bdev_nr_bytes instead of open coding it · Christoph Hellwig · 2021-10-15
Re: [PATCH 12/30] btrfs: use bdev_nr_bytes instead of open coding it · David Sterba · 2021-10-15
Re: [PATCH 12/30] btrfs: use bdev_nr_bytes instead of open coding it · Kees Cook · 2021-10-15
[PATCH 11/30] affs: use bdev_nr_sectors instead of open coding it · Christoph Hellwig · 2021-10-15
Re: [PATCH 11/30] affs: use bdev_nr_sectors instead of open coding it · Chaitanya Kulkarni · 2021-10-18
[PATCH 13/30] cramfs: use bdev_nr_bytes instead of open coding it · Christoph Hellwig · 2021-10-15
Re: [PATCH 13/30] cramfs: use bdev_nr_bytes instead of open coding it · Kees Cook · 2021-10-15
[PATCH 14/30] fat: use bdev_nr_sectors instead of open coding it · Christoph Hellwig · 2021-10-15
[PATCH 15/30] hfs: use bdev_nr_sectors instead of open coding it · Christoph Hellwig · 2021-10-15
[PATCH 16/30] hfsplus: use bdev_nr_sectors instead of open coding it · Christoph Hellwig · 2021-10-15
[PATCH 17/30] jfs: use bdev_nr_bytes instead of open coding it · Christoph Hellwig · 2021-10-15
Re: [PATCH 17/30] jfs: use bdev_nr_bytes instead of open coding it · Kees Cook · 2021-10-15
[PATCH 18/30] nfs/blocklayout: use bdev_nr_bytes instead of open coding it · Christoph Hellwig · 2021-10-15
Re: [PATCH 18/30] nfs/blocklayout: use bdev_nr_bytes instead of open coding it · Kees Cook · 2021-10-15
[PATCH 20/30] ntfs3: use bdev_nr_bytes instead of open coding it · Christoph Hellwig · 2021-10-15
Re: [PATCH 20/30] ntfs3: use bdev_nr_bytes instead of open coding it · Kees Cook · 2021-10-15
Re: [PATCH 20/30] ntfs3: use bdev_nr_bytes instead of open coding it · Kari Argillander · 2021-10-16
[PATCH 19/30] nilfs2: use bdev_nr_bytes instead of open coding it · Christoph Hellwig · 2021-10-15
Re: [PATCH 19/30] nilfs2: use bdev_nr_bytes instead of open coding it · Ryusuke Konishi · 2021-10-15
Re: [PATCH 19/30] nilfs2: use bdev_nr_bytes instead of open coding it · Kees Cook · 2021-10-15
[PATCH 22/30] reiserfs: use bdev_nr_bytes instead of open coding it · Christoph Hellwig · 2021-10-15
Re: [PATCH 22/30] reiserfs: use bdev_nr_bytes instead of open coding it · Kees Cook · 2021-10-15
Re: [PATCH 22/30] reiserfs: use bdev_nr_bytes instead of open coding it · Chaitanya Kulkarni · 2021-10-18
[PATCH 21/30] pstore/blk: use bdev_nr_bytes instead of open coding it · Christoph Hellwig · 2021-10-15
Re: [PATCH 21/30] pstore/blk: use bdev_nr_bytes instead of open coding it · Kees Cook · 2021-10-15
[PATCH 23/30] squashfs: use bdev_nr_bytes instead of open coding it · Christoph Hellwig · 2021-10-15
Re: [PATCH 23/30] squashfs: use bdev_nr_bytes instead of open coding it · Kees Cook · 2021-10-15
[PATCH 24/30] block: use bdev_nr_bytes instead of open coding it in blkdev_fallocate · Christoph Hellwig · 2021-10-15
Re: [PATCH 24/30] block: use bdev_nr_bytes instead of open coding it in blkdev_fallocate · Kees Cook · 2021-10-15
[PATCH 25/30] block: add a sb_bdev_nr_blocks helper · Christoph Hellwig · 2021-10-15
Re: [PATCH 25/30] block: add a sb_bdev_nr_blocks helper · Kees Cook · 2021-10-15
Re: [PATCH 25/30] block: add a sb_bdev_nr_blocks helper · Chaitanya Kulkarni · 2021-10-18
[PATCH 26/30] ext4: use sb_bdev_nr_blocks · Christoph Hellwig · 2021-10-15
Re: [PATCH 26/30] ext4: use sb_bdev_nr_blocks · Chaitanya Kulkarni · 2021-10-18
[PATCH 27/30] jfs: use sb_bdev_nr_blocks · Christoph Hellwig · 2021-10-15
Re: [PATCH 27/30] jfs: use sb_bdev_nr_blocks · Dave Kleikamp · 2021-10-15
[PATCH 28/30] ntfs: use sb_bdev_nr_blocks · Christoph Hellwig · 2021-10-15
Re: [PATCH 28/30] ntfs: use sb_bdev_nr_blocks · Anton Altaparmakov · 2021-10-15
[PATCH 29/30] reiserfs: use sb_bdev_nr_blocks · Christoph Hellwig · 2021-10-15
[PATCH 30/30] udf: use sb_bdev_nr_blocks · Christoph Hellwig · 2021-10-15
View all 63 messages

`h`	back out one level
`j`	next message in thread / next series-diff position
`k`	previous message in thread / previous series-diff position
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help