Re: [PATCH 01/17] mm: don't include <linux/blk-cgroup.h> in <linux/writeback.h>

From
Christoph Hellwig <hch@lst.de>
Date
2021-09-21 06:37:01
Also in
linux-mm
Reply to
Bart Van Assche, 2021-09-20
On Mon, Sep 20, 2021 at 03:13:15PM -0700, Bart Van Assche wrote:
quoted
+#define wbc_blkcg_css(wbc) \
+	((wbc)->wb ? (wbc)->wb->blkcg_css : blkcg_root_css)
+#else
+#define wbc_blkcg_css(wbc)		(blkcg_root_css)
+#endif /* CONFIG_CGROUP_WRITEBACK */
This change may introduce annoying set-but-not-used warnings
with CONFIG_CGROUP_WRITEBACK=n. How about changing (blkcg_root_css)
into ((wbc), blkcg_root_css) to prevent this?
I agree in principle, but in this case the caller pretty much has
to use wbc in other ways, so I don't think it matters much.
Thread (28 messages) 28 messages, 4 authors, last reply 2021-09-27
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help