Re: [PATCH 01/17] mm: don't include <linux/blk-cgroup.h> in <linux/writeback.h>

From
Bart Van Assche <bvanassche@acm.org>
Date
2021-09-20 22:15:19
Also in
linux-mm
Reply to
Christoph Hellwig, 2021-09-20
On 9/20/21 5:33 AM, Christoph Hellwig wrote:
quoted hunk ↗ jump to hunk
-static inline struct cgroup_subsys_state *
-wbc_blkcg_css(struct writeback_control *wbc)
-{
  #ifdef CONFIG_CGROUP_WRITEBACK
-	if (wbc->wb)
-		return wbc->wb->blkcg_css;
-#endif
-	return blkcg_root_css;
-}
+#define wbc_blkcg_css(wbc) \
+	((wbc)->wb ? (wbc)->wb->blkcg_css : blkcg_root_css)
+#else
+#define wbc_blkcg_css(wbc)		(blkcg_root_css)
+#endif /* CONFIG_CGROUP_WRITEBACK */
This change may introduce annoying set-but-not-used warnings
with CONFIG_CGROUP_WRITEBACK=n. How about changing (blkcg_root_css)
into ((wbc), blkcg_root_css) to prevent this?

Thanks,

Bart.
Thread (28 messages) 28 messages, 4 authors, last reply 2021-09-27
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help