Re: [PATCH 2/3] nvdimm/pmem: move dax_attribute_group from dax to pmem
From: Dan Williams <hidden>
Date: 2021-09-21 02:17:40
Also in:
nvdimm, oe-kbuild-all
On Mon, Sep 20, 2021 at 11:01 AM kernel test robot [off-list ref] wrote:
Hi Christoph, I love your patch! Yet something to improve: [auto build test ERROR on axboe-block/for-next] [also build test ERROR on linus/master v5.15-rc2 next-20210920] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Christoph-Hellwig/nvdimm-pmem-fix-creating-the-dax-group/20210920-162804 base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next config: riscv-buildonly-randconfig-r006-20210920 (attached as .config) compiler: riscv64-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/1a16d0f32f70bcd159a9f8cf32794f4024e8711e git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Christoph-Hellwig/nvdimm-pmem-fix-creating-the-dax-group/20210920-162804 git checkout 1a16d0f32f70bcd159a9f8cf32794f4024e8711e # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=riscv If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <redacted> All errors (new ones prefixed by >>): drivers/dax/super.c:375:6: error: no previous prototype for 'run_dax' [-Werror=missing-prototypes] 375 | void run_dax(struct dax_device *dax_dev) | ^~~~~~~
In this new -Werror world drivers/dax/bus.c needs: #include "bus.h"
quoted
quoted
drivers/dax/super.c:70:27: error: 'dax_get_by_host' defined but not used [-Werror=unused-function]70 | static struct dax_device *dax_get_by_host(const char *host) | ^~~~~~~~~~~~~~~ cc1: all warnings being treated as errors
Nice additional cleanup that now fs_dax_get_by_bdev() is the only caller of dax_get_by_host().