Re: [PATCH 1/3] nvdimm/pmem: fix creating the dax group
From: Dan Williams <hidden>
Date: 2021-09-21 02:17:40
Also in:
nvdimm
On Mon, Sep 20, 2021 at 12:29 AM Christoph Hellwig [off-list ref] wrote:
The recent block layer refactoring broke the way how the pmem driver
abused device_add_disk. Fix this by properly passing the attribute groups
to device_add_disk.
Fixes: 52b85909f85d ("block: fold register_disk into device_add_disk")
This also fixes the the way the pmem driver abused device_add_disk(),
so perhaps add:
Fixes: fef912bf860e ("block: genhd: add 'groups' argument to device_add_disk")
...as well. It's not a stable fix as this is only a cosmetic fixup
until the most recent refactoring turned it into a bug.
Either way, you can add:
Reviewed-by: Dan Williams <redacted>