On Mon, Aug 23, 2021 at 4:07 PM Max Gurtovoy [off-list ref] wrote:

On 8/23/2021 7:31 AM, Yongji Xie wrote:

quoted

On Mon, Aug 23, 2021 at 7:17 AM Max Gurtovoy [off-list ref] wrote:

quoted

On 8/9/2021 1:16 PM, Xie Yongji wrote:

quoted

An untrusted device might presents an invalid block size
in configuration space. This tries to add validation for it
in the validate callback and clear the VIRTIO_BLK_F_BLK_SIZE
feature bit if the value is out of the supported range.

This is not clear to me. What is untrusted device ? is it a buggy device ?

A buggy device, the devices in an encrypted VM, or a userspace device
created by VDUSE [1].

[1] https://lore.kernel.org/kvm/20210818120642.165-1-xieyongji@bytedance.com/ (local)

if it's a userspace device, why don't you fix its control path code
instead of adding workarounds in the kernel driver ?

VDUSE kernel module would not touch (be aware of) the device specific
configuration space. It should be more reasonable to fix it in the
device driver. There is also some existing interface (.validate()) for
doing that.

And regardless of userspace device, we still need to fix it for other cases.

Thanks,
Yongji