Thread (36 messages) flat view 36 messages, 2 authors, 2021-07-22

Re: [PATCH 12/24] block: add a queue_max_sectors_bytes helper

From: Christoph Hellwig <hch@lst.de>
Date: 2021-07-22 19:08:37
Also in: linux-scsi

On Thu, Jul 22, 2021 at 10:37:36AM -0700, Bart Van Assche wrote:
On 7/11/21 10:48 PM, Christoph Hellwig wrote:
quoted
+static inline int queue_max_sectors_bytes(struct request_queue *q)
+{
+	return min_t(unsigned int, queue_max_sectors(q), INT_MAX >> 9) << 9;
+}
Should this function return a signed or an unsigned integer? I'm asking 
because I see 'unsigned int' as the first argument for min_t().
Yes, it really should be unsigned.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help