Re: [PATCH 17/24] scsi_ioctl: simplify SCSI passthrough permission checking

On 7/11/21 10:48 PM, Christoph Hellwig wrote:

+bool scsi_cmd_allowed(unsigned char *cmd, fmode_t mode)
  {

The first time I encountered this function it was not clear to me what 
the purpose of this function is. I think this is a good time to add a 
comment above this function that explains its purpose, namely to prevent 
that unprivileged SG I/O users can modify storage device firmware.

Thanks,

Bart.