Re: [PATCH 06/11] mmc: core: Prepare mmc_send_cxd_data() to be re-used for additional cmds
From: Linus Walleij <hidden>
Date: 2021-05-06 13:00:43
Also in:
linux-mmc, lkml
From: Linus Walleij <hidden>
Date: 2021-05-06 13:00:43
Also in:
linux-mmc, lkml
On Tue, May 4, 2021 at 6:12 PM Ulf Hansson [off-list ref] wrote:
* NOTE: void *buf, caller for the buf is required to use DMA-capable * buffer or on-stack buffer (with some overhead in callee). */ -static int -mmc_send_cxd_data(struct mmc_card *card, struct mmc_host *host, - u32 opcode, void *buf, unsigned len) +int mmc_send_adtc_data(struct mmc_card *card, struct mmc_host *host, u32 opcode, + u32 args, void *buf, unsigned len)
Just a note here (the change is good) When applying please add some kerneldoc above mmc_send_adtc_data() and expand the ADTC acronym and add some info explaining what it is maybe a small protocol ref or so, so readers of the code get an intuitive feeling for what this function does and what ADTC is. Yours, Linus Walleijq