Thread (7 messages) 7 messages, 3 authors, 2021-04-08

Re: [PATCH V5 2/3] block: add a statistic table for io latency

From: Haris Iqbal <haris.iqbal@ionos.com>
Date: 2021-04-08 17:06:55

On Thu, Apr 8, 2021 at 6:52 PM Christoph Hellwig [off-list ref] wrote:
quoted
+static ssize_t io_latency_show(struct device *dev, struct device_attribute *attr, char *buf)
+{
+     struct block_device *bdev = dev_to_bdev(dev);
+     size_t count = 0;
+     int i, sgrp;
+
+     for (i = 0; i < ADD_STAT_NUM; i++) {
+             unsigned int from, to;
+
+             if (i == ADD_STAT_NUM - 1) {
+                     count += scnprintf(buf + count, PAGE_SIZE - count, "      >= %5d  ms: ",
Please fix your overly long lines all over this code.
Sure, will do.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help