Re: [PATCH V5 2/3] block: add a statistic table for io latency
From: Christoph Hellwig <hch@infradead.org>
Date: 2021-04-08 16:52:24
From: Christoph Hellwig <hch@infradead.org>
Date: 2021-04-08 16:52:24
+static ssize_t io_latency_show(struct device *dev, struct device_attribute *attr, char *buf)
+{
+ struct block_device *bdev = dev_to_bdev(dev);
+ size_t count = 0;
+ int i, sgrp;
+
+ for (i = 0; i < ADD_STAT_NUM; i++) {
+ unsigned int from, to;
+
+ if (i == ADD_STAT_NUM - 1) {
+ count += scnprintf(buf + count, PAGE_SIZE - count, " >= %5d ms: ",Please fix your overly long lines all over this code.