On 2021/1/21 16:40, Christoph Hellwig wrote:

On Thu, Jan 21, 2021 at 03:03:26PM +0800, Chao Leng wrote:

quoted

nvme drivers need to set the state of request to MQ_RQ_COMPLETE when
directly complete request in queue_rq.
So add blk_mq_set_request_complete.

So I'm not happy with this helper.  It should at least:

  a) be named and documented to only apply for the ->queue_rq faіlure case

Although blk_mq_complete_request_remote can set the markup directly,
blk_mq_complete_request_remote can also use this helper. This helper do
not need special processing for ->queue_rq failure.

  b) check that the request is in MQ_RQ_IDLE state

No, the request may also be in MQ_RQ_IN_FLIGHT state. Do not need to
care whether the original state is MQ_RQ_IDLE or MQ_RQ_IN_FLIGHT.

.