Re: [PATCH V3 5/6] block: move three bvec helpers declaration into private helper

From
Hannes Reinecke <hare@suse.de>
Date
2021-01-11 07:00:53
Reply to
Ming Lei, 2021-01-11
On 1/11/21 4:05 AM, Ming Lei wrote:
quoted hunk ↗ jump to hunk
bvec_alloc(), bvec_free() and bvec_nr_vecs() are only used inside block
layer core functions, no need to declare them in public header.

Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Ming Lei <redacted>
---
  block/blk.h         | 4 ++++
  include/linux/bio.h | 3 ---
  2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/block/blk.h b/block/blk.h
index 7550364c326c..a21a35c4a3e4 100644
--- a/block/blk.h
+++ b/block/blk.h
@@ -55,6 +55,10 @@ void blk_free_flush_queue(struct blk_flush_queue *q);
  
  void blk_freeze_queue(struct request_queue *q);
  
+struct bio_vec *bvec_alloc(gfp_t, int, unsigned long *, mempool_t *);
+void bvec_free(mempool_t *, struct bio_vec *, unsigned int);
+unsigned int bvec_nr_vecs(unsigned short idx);
+
  static inline bool biovec_phys_mergeable(struct request_queue *q,
  		struct bio_vec *vec1, struct bio_vec *vec2)
  {
diff --git a/include/linux/bio.h b/include/linux/bio.h
index f606eb1e556f..70914dd6a70d 100644
--- a/include/linux/bio.h
+++ b/include/linux/bio.h
@@ -478,9 +478,6 @@ static inline void zero_fill_bio(struct bio *bio)
  	zero_fill_bio_iter(bio, bio->bi_iter);
  }
  
-extern struct bio_vec *bvec_alloc(gfp_t, int, unsigned long *, mempool_t *);
-extern void bvec_free(mempool_t *, struct bio_vec *, unsigned int);
-extern unsigned int bvec_nr_vecs(unsigned short idx);
  extern const char *bio_devname(struct bio *bio, char *buffer);
  
  #define bio_set_dev(bio, bdev) 			\
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Kernel Storage Architect
hare@suse.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
Thread (22 messages) 22 messages, 5 authors, last reply 2021-01-25
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help