Re: [PATCH V3 4/6] block: set .bi_max_vecs as actual allocated vector number

From
Hannes Reinecke <hare@suse.de>
Date
2021-01-11 07:00:26
Reply to
Ming Lei, 2021-01-11
On 1/11/21 4:05 AM, Ming Lei wrote:
quoted hunk ↗ jump to hunk
bvec_alloc() may allocate more bio vectors than requested, so set
.bi_max_vecs as actual allocated vector number, instead of the requested
number. This way can help fs build bigger bio because new bio often won't
be allocated until the current one becomes full.

Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Ming Lei <redacted>
---
  block/bio.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/block/bio.c b/block/bio.c
index 496aa5938f79..37e3f2d9df99 100644
--- a/block/bio.c
+++ b/block/bio.c
@@ -505,12 +505,13 @@ struct bio *bio_alloc_bioset(gfp_t gfp_mask, unsigned int nr_iovecs,
  			goto err_free;
  
  		bio->bi_flags |= idx << BVEC_POOL_OFFSET;
+		bio->bi_max_vecs = bvec_nr_vecs(idx);
  	} else if (nr_iovecs) {
  		bvl = bio->bi_inline_vecs;
+		bio->bi_max_vecs = inline_vecs;
  	}
  
  	bio->bi_pool = bs;
-	bio->bi_max_vecs = nr_iovecs;
  	bio->bi_io_vec = bvl;
  	return bio;
  
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Kernel Storage Architect
hare@suse.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
Thread (22 messages) 22 messages, 5 authors, last reply 2021-01-25
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help