Re: [PATCH 1/2] mtip32xx: use PCI #defines instead of numbers
From: Bjorn Helgaas <helgaas@kernel.org>
Date: 2021-01-27 15:23:43
Also in:
lkml
From: Bjorn Helgaas <helgaas@kernel.org>
Date: 2021-01-27 15:23:43
Also in:
lkml
On Wed, Jan 27, 2021 at 07:58:26AM +0000, Chaitanya Kulkarni wrote:
quoted
On Jan 26, 2021, at 11:41 PM, Chaitanya Kulkarni [off-list ref] wrote: On 1/26/21 14:14, Bjorn Helgaas wrote:quoted
From: Bjorn Helgaas <bhelgaas@google.com> Use PCI #defines for PCIe Device Control register values instead of hard-coding bit positions. No functional change intended. Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>I've verified the values present in the include/uapi/linux/pci_regs.h matches open coded bit shift values. LGTM. Reviewed-by: Chaitanya Kulkarni <redacted>Something is seriously wrong. I sent out this in the morning and it got delivered right now.
I noticed that, too. Seems like the mailing list is really backed up. Thanks a lot for taking a look at this! Bjorn