Re: [PATCH 1/2] mtip32xx: use PCI #defines instead of numbers

[PATCH 0/2] mtip32xx: minor PCI cleanups · Bjorn Helgaas <helgaas@kernel.org> · 2021-01-27
[PATCH 1/2] mtip32xx: use PCI #defines instead of numbers · Bjorn Helgaas <helgaas@kernel.org> · 2021-01-27
Re: [PATCH 1/2] mtip32xx: use PCI #defines instead of numbers · Chaitanya Kulkarni <hidden> · 2021-01-27
Re: [PATCH 1/2] mtip32xx: use PCI #defines instead of numbers · Chaitanya Kulkarni <hidden> · 2021-01-27
Re: [PATCH 1/2] mtip32xx: use PCI #defines instead of numbers · Bjorn Helgaas <helgaas@kernel.org> · 2021-01-27
[PATCH 2/2] mtip32xx: prefer pcie_capability_read_word() · Bjorn Helgaas <helgaas@kernel.org> · 2021-01-27
Re: [PATCH 0/2] mtip32xx: minor PCI cleanups · Jens Axboe <axboe@kernel.dk> · 2021-01-27

From: Chaitanya Kulkarni <hidden>
Date: 2021-01-27 08:13:26
Also in: lkml

On Jan 26, 2021, at 11:41 PM, Chaitanya Kulkarni [off-list ref] wrote:

On 1/26/21 14:14, Bjorn Helgaas wrote:

quoted

From: Bjorn Helgaas <bhelgaas@google.com>

Use PCI #defines for PCIe Device Control register values instead of
hard-coding bit positions.  No functional change intended.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>

I've verified the values present in the include/uapi/linux/pci_regs.h
matches open coded bit shift values. LGTM.

Reviewed-by: Chaitanya Kulkarni <redacted>

Something is seriously wrong. I sent out this in the morning and it got delivered right now.

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help