Re: [PATCH V2 2/9] nvmet: add ZNS support for bdev-ns

On 11/30/20 04:29, Johannes Thumshirn wrote:

On 30/11/2020 04:32, Chaitanya Kulkarni wrote:

quoted

+	ret =  __bio_iov_append_get_pages(bio, &from);

Can't you just use bio_iov_iter_get_pages() here?

It does have a 

if (WARN_ON_ONCE(is_bvec))
	return -EINVAL;

in it but I think that can be deleted.

That was my initial patch but it adds an extra function call to the

fast patch for NVMeOF. We don't need any of the generic functionality from

bio_iov_iter_get_pages() anyway.


Why add an extra function call overhead in the hot path for each I/O ?