Re: [PATCH V2 8/9] nvmet: add zns bdev config support
From: Damien Le Moal <hidden>
Date: 2020-11-30 12:03:57
Also in:
linux-nvme
From: Damien Le Moal <hidden>
Date: 2020-11-30 12:03:57
Also in:
linux-nvme
On 2020/11/30 12:30, Chaitanya Kulkarni wrote:
For zbd based bdev backend we need to override the ns->blksize_shift with the physical block size instead of using the logical block size so that SMR drives will not result in an error. Update the nvmet_bdev_ns_enable() to reflect that. Signed-off-by: Chaitanya Kulkarni <redacted> --- drivers/nvme/target/io-cmd-bdev.c | 3 +++ 1 file changed, 3 insertions(+)diff --git a/drivers/nvme/target/io-cmd-bdev.c b/drivers/nvme/target/io-cmd-bdev.c index 125dde3f410e..e1f6d59dd341 100644 --- a/drivers/nvme/target/io-cmd-bdev.c +++ b/drivers/nvme/target/io-cmd-bdev.c@@ -86,6 +86,9 @@ int nvmet_bdev_ns_enable(struct nvmet_ns *ns) if (IS_ENABLED(CONFIG_BLK_DEV_INTEGRITY_T10)) nvmet_bdev_ns_enable_integrity(ns); + if (bdev_is_zoned(ns->bdev) && !nvmet_bdev_zns_enable(ns)) + return -EINVAL; + return 0; }
I think this should be merged with patch 9. I do not see the point in having this as a separate patch. -- Damien Le Moal Western Digital Research