RE: [PATCH] [v2] blk-mq-tag: make blk_mq_tag_busy() return void
From: Tianxianting <hidden>
Date: 2020-12-10 06:25:25
Also in:
lkml
Yes, Sorry, In V2. I missed it, so I sent v3 :) -----Original Message----- From: Chaitanya Kulkarni [mailto:Chaitanya.Kulkarni@wdc.com] Sent: Thursday, December 10, 2020 2:21 PM To: tianxianting (RD) <redacted>; axboe@kernel.dk Cc: ming.lei@redhat.com; linux-block@vger.kernel.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH] [v2] blk-mq-tag: make blk_mq_tag_busy() return void On 12/9/20 22:06, Xianting Tian wrote:
quoted hunk ↗ jump to hunk
As no one cares about the return value of blk_mq_tag_busy() and __blk_mq_tag_busy(), so make them return void. Other change is to simplify blk_mq_tag_idle(). Signed-off-by: Xianting Tian <redacted> Reviewed-by: Ming Lei <redacted> --- block/blk-mq-tag.c | 4 ++-- block/blk-mq-tag.h | 16 ++++++---------- 2 files changed, 8 insertions(+), 12 deletions(-)diff --git a/block/blk-mq-tag.c b/block/blk-mq-tag.c index9c92053e7..21ff7d156 100644--- a/block/blk-mq-tag.c +++ b/block/blk-mq-tag.c@@ -21,7 +21,7 @@ * to get tag when first time, the other shared-tag users could reserve * budget for it. */ -bool __blk_mq_tag_busy(struct blk_mq_hw_ctx *hctx) +void __blk_mq_tag_busy(struct blk_mq_hw_ctx *hctx) { if (blk_mq_is_sbitmap_shared(hctx->flags)) { struct request_queue *q = hctx->queue; @@ -36,7 +36,7 @@ bool__blk_mq_tag_busy(struct blk_mq_hw_ctx *hctx) atomic_inc(&hctx->tags->active_queues); } - return true; + return;
if above return is the last statement then you need to remove that instead of using return with no value. Also, please add the version history.