Thread (3 messages) 3 messages, 2 authors, 2020-12-10

Re: [PATCH] [v2] blk-mq-tag: make blk_mq_tag_busy() return void

From: Chaitanya Kulkarni <hidden>
Date: 2020-12-10 06:23:21
Also in: lkml

On 12/9/20 22:06, Xianting Tian wrote:
quoted hunk ↗ jump to hunk
As no one cares about the return value of blk_mq_tag_busy() and
__blk_mq_tag_busy(), so make them return void.

Other change is to simplify blk_mq_tag_idle().

Signed-off-by: Xianting Tian <redacted>
Reviewed-by: Ming Lei <redacted>
---
 block/blk-mq-tag.c |  4 ++--
 block/blk-mq-tag.h | 16 ++++++----------
 2 files changed, 8 insertions(+), 12 deletions(-)
diff --git a/block/blk-mq-tag.c b/block/blk-mq-tag.c
index 9c92053e7..21ff7d156 100644
--- a/block/blk-mq-tag.c
+++ b/block/blk-mq-tag.c
@@ -21,7 +21,7 @@
  * to get tag when first time, the other shared-tag users could reserve
  * budget for it.
  */
-bool __blk_mq_tag_busy(struct blk_mq_hw_ctx *hctx)
+void __blk_mq_tag_busy(struct blk_mq_hw_ctx *hctx)
 {
 	if (blk_mq_is_sbitmap_shared(hctx->flags)) {
 		struct request_queue *q = hctx->queue;
@@ -36,7 +36,7 @@ bool __blk_mq_tag_busy(struct blk_mq_hw_ctx *hctx)
 			atomic_inc(&hctx->tags->active_queues);
 	}
 
-	return true;
+	return;
if above return is the last statement then you need to remove that
instead of using return with no value.

Also, please add the version history.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help