Re: [PATCH blktests 2/5] tests/nvmeof-mp/rc: run nvmeof-mp tests if we set multipath=N
From: Bart Van Assche <bvanassche@acm.org>
Date: 2020-11-25 03:52:13
Also in:
linux-nvme
On 11/24/20 6:04 AM, Yi Zhang wrote:
quoted hunk ↗ jump to hunk
Do you mean something like this, could you add more detail here, thanks.diff --git a/tests/nvmeof-mp/rc b/tests/nvmeof-mp/rc index d7a7c87..af700d9 100755 --- a/tests/nvmeof-mp/rc +++ b/tests/nvmeof-mp/rc@@ -16,9 +16,9 @@ group_requires() {# Since the nvmeof-mp tests are based on the dm-mpath driver, these # tests are incompatible with the NVME_MULTIPATH kernel configuration - # option. - if _have_kernel_option NVME_MULTIPATH; then - SKIP_REASON="CONFIG_NVME_MULTIPATH has been set in .config" + # option and nvme_core: multipath set with Y. + if _have_kernel_option NVME_MULTIPATH && _have_module_param_value nvme_core multipath Y; then + SKIP_REASON="CONFIG_NVME_MULTIPATH has been set in .config and nvme_core: multipath should be set with N" return fi
I may have sent you in the wrong direction. This is what I meant: if _have_kernel_option NVME_MULTIPATH && _have_module_param_value nvme_core multipath Y; then SKIP_REASON="CONFIG_NVME_MULTIPATH has been set in .config and multipathing has been enabled in the nvme_core kernel module" return fi Thanks, Bart.