Thread (18 messages) 18 messages, 2 authors, 2020-11-25

Re: [PATCH blktests 3/5] tests/nvmeof-mp/012: fix the schedulers list

From: Bart Van Assche <bvanassche@acm.org>
Date: 2020-11-24 03:28:54
Also in: linux-nvme

On 11/23/20 5:04 PM, Yi Zhang wrote:
There is no cfg scheduler and new added kyber scheduler in lastest kernel,
              ^^^
              cfq?
so get the scheduler from sysfs
[ ... ]
quoted hunk ↗ jump to hunk
 	# Load all I/O scheduler kernel modules
 	for m in "/lib/modules/$(uname -r)/kernel/block/"*.ko; do
@@ -17,15 +17,17 @@ test_io_schedulers() {
 	for mq in y n; do
 		use_blk_mq ${mq} || return $?
 		dev=$(get_bdev 0) || return $?
-		for sched in noop deadline bfq cfq; do
-			set_scheduler "$(basename "$(readlink -f "${dev}")")" $sched \
+		dm=$(basename "$(readlink -f "${dev}")") || return $?
+		scheds=$(sed 's/[][]//g' /sys/block/"$dm"/queue/scheduler) || return $?
+		for sched in $scheds; do
+			set_scheduler "$dm" "$sched" \
Similar code occurs in tests/srp/012. Please introduce a function for
retrieving the scheduler list and also update tests/srp/012.

Thanks,

Bart.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help