Re: [PATCH RESEND 5/5] block: Remove __blk_mq_sched_bio_merge() helper
From: Baolin Wang <baolin.wang@linux.alibaba.com>
Date: 2020-08-18 03:29:43
Also in:
lkml
On Mon, Aug 17, 2020 at 02:26:08PM +0200, Christoph Hellwig wrote:
On Mon, Aug 17, 2020 at 08:14:08PM +0800, Baolin Wang wrote:quoted
On Mon, Aug 17, 2020 at 08:32:41AM +0200, Christoph Hellwig wrote:quoted
On Mon, Aug 17, 2020 at 12:09:19PM +0800, Baolin Wang wrote:quoted
The blk_mq_sched_bio_merge() just wrap the __blk_mq_sched_bio_merge(), and no other places will use __blk_mq_sched_bio_merge(). Thus we can combine these 2 similar functions into one function.I think the idea was to avoid the function call for the nomerges fast path. Not sure if that is really worth it.Um, no places will use __blk_mq_sched_bio_merge(), not sure if it is a good choice we still keep an unused and similar function?Well, blk_mq_sched_bio_merge calls __blk_mq_sched_bio_merge, after performing two fast path checks.
What I mean is blk_mq_sched_bio_merge() just wrap the __blk_mq_sched_bio_merge(), and no other users will call __blk_mq_sched_bio_merge(). Anyway, I will drop this patch as you suggested.