Re: [PATCH RESEND 2/5] block: Remove redundant blk_mq_sched_allow_merge() validation

On Mon, Aug 17, 2020 at 08:22:24AM +0200, Christoph Hellwig wrote:

On Mon, Aug 17, 2020 at 12:09:16PM +0800, Baolin Wang wrote:

quoted

Only software queue and kyber IO scheduler will call blk_mq_bio_list_merge()
to merge a bio, and kyber IO scheduler did not implement the ops->allow_merge().

Please line wrap your changelogs after 73 characters.

Sure.

quoted

Thus we can remove the redundant blk_mq_sched_allow_merge() in
blk_mq_bio_list_merge() function.

This seems potentially dangerous, and I don't think it really buys
us much.

OK. I can remove this in next version.